Add SyncIndexes schema upgrade mode #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add extension methods on IActionSequnece to check whether it contains expected actions Add condition in upgrade process for syncing indexes Add tests Bump version
Orm/Xtensive.Orm/Modelling/Actions/Extensions/ActionSequenceExtensions.cs
Outdated
Show resolved
Hide resolved
Orm/Xtensive.Orm/Modelling/Actions/Extensions/ActionSequenceExtensions.cs
Outdated
Show resolved
Hide resolved
SergeiPavlov
approved these changes
Feb 29, 2024
SergeiPavlov
reviewed
Mar 1, 2024
| if (result.HasUnsafeActions || | ||
| !result.UpgradeActions.ContainsOnlyModificationOf<SecondaryIndexInfo>()) | ||
| throw new SchemaSynchronizationException(result); | ||
| goto case SchemaUpgradeMode.Perform; |
There was a problem hiding this comment.
Lets change this to goto case SchemaUpgradeMode.PerformSafely; and remove if (result.HasUnsafeActions checking
May be to rename this enum constant to .SyncIndexesSafely ?
SergeiPavlov
reviewed
Mar 1, 2024
| if (result.HasUnsafeActions || | ||
| !result.UpgradeActions.ContainsOnlyModificationOf<SecondaryIndexInfo>()) | ||
| throw new SchemaSynchronizationException(result); | ||
| goto case SchemaUpgradeMode.Perform; |
SergeiPavlov
reviewed
Mar 1, 2024
Version.props
Outdated
| @@ -2,7 +2,7 @@ | |||
| <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
|
|
|||
| <PropertyGroup> | |||
| <DoVersion>7.2.0.115</DoVersion> | |||
| <DoVersion>7.2.0.116</DoVersion> | |||
There was a problem hiding this comment.
Please don't bump version in Pull Request
Because some other PRs may be merged earlier
I'm bumping it in master-servicetitan branch just before deploying nuget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extension methods on IActionSequnece to check whether it contains expected actions
Add condition in upgrade process for syncing indexes Add tests
Bump version