Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PostgreSQL tests into GitHub action workflow. Fix a few breaking changes in PostgreSQL driver #226

Merged
merged 27 commits into from
May 9, 2024

Conversation

SergeiPavlov
Copy link
Collaborator

@SergeiPavlov SergeiPavlov commented May 7, 2024

Also:

  • MutePostgreSql attribute to mute some failed tests temporary
  • Init Postgres connections with SET TIME ZONE 'UTC' to avoid mess with Client/Server timezones

@SergeiPavlov SergeiPavlov requested a review from botinko as a code owner May 7, 2024 22:56
@SergeiPavlov SergeiPavlov changed the title Add GitHub Actions workflow for PostgreSQL tests. Fix a few breaking changes in PostgreSQL driver Add PostgreSQL tests into GitHub action workflow. Fix a few breaking changes in PostgreSQL driver May 7, 2024
Copy link

@botinko botinko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the plans on tests with MutePostgreSql ?

@SergeiPavlov
Copy link
Collaborator Author

What are the plans on tests with MutePostgreSql ?

I will investigate them later. Most of them are related to complicated DateTime logic in Postgres and breaking changes with Timestamp type in Npgsql nuget.

The App need not special Local Time processing on DB level, so we can ignore these issues.

@SergeiPavlov SergeiPavlov merged commit 3364c0c into master-servicetitan May 9, 2024
2 checks passed
@SergeiPavlov SergeiPavlov deleted the PostgresTests branch May 9, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants