Add .NET9 compatibility #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botinko
reviewed
Jan 6, 2025
| @@ -18,6 +18,7 @@ namespace Xtensive.Orm.Tests.Core.Comparison | |||
| [TestFixture] | |||
| public class ComparerProviderTests | |||
| { | |||
| [Explicit] | |||
There was a problem hiding this comment.
Looks like tests needs to be fixed, not just ignored.
There was a problem hiding this comment.
The disabled tests rely on BinarySerialization which does not work anymore
To fix the tests we have to invent some replacement of BinarySerialization.
Not sure it is our business
It is better to remove this functionality from DataObjects
We don't use it anyway
botinko
reviewed
Jan 6, 2025
botinko
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fieldis a context keyword now, renamefieldidentifiers tofld.Serializationtests as[Explicit]becauseBinaryFormatteris removed from .NET9