Compress Model XML, Stage 3: assign [MetatdataExtension].Value = null to get rid of Uncompressed XML
#333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeiPavlov
changed the title
Extension.Value = nullExtension.Value = null
SergeiPavlov
changed the title
Extension.Value = nullExtension.Value = null
SergeiPavlov
changed the title
Extension.Value = null[MetatdataExtension].Value = null
SergeiPavlov
changed the title
[MetatdataExtension].Value = null[MetatdataExtension].Value = null to get rid of Uncompressed XML
snaumenko-st
approved these changes
Jan 14, 2025
| switch (data[0]) { | ||
| case 0: | ||
| xml = Encoding.UTF8.GetString(data, 1, data.Length - 1); | ||
| break; | ||
| return Serializer.Deserialize(Encoding.UTF8.GetString(data, 1, data.Length - 1)); |
There was a problem hiding this comment.
Maybe we can deserialize here from stream as well? To get rid of intermediate string
There was a problem hiding this comment.
This code will not be active anyway.
0-method means "Non-compressed", not used.
botinko
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
SimpleXmlSerializer.SerializeIntoStream()/.DeserializeFromStream()methods for optimal XML processingWe will apply this PR starting
73.1quasar