Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of unused class Deque<> #339

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Get rid of unused class Deque<> #339

merged 2 commits into from
Jan 15, 2025

Conversation

SergeiPavlov
Copy link
Collaborator

The only usage was actually List<>'s functionality

Also:

  • Derive OperationRegistry from List<> to save an allocation

@SergeiPavlov SergeiPavlov changed the title Get rid of unused Dequeue<> Get rid of unused Deque<> Jan 15, 2025
@SergeiPavlov SergeiPavlov changed the title Get rid of unused Deque<> Get rid of unused class Deque<> Jan 15, 2025
@botinko botinko self-requested a review January 15, 2025 19:28
@SergeiPavlov SergeiPavlov merged commit 6d66e27 into master-servicetitan Jan 15, 2025
4 checks passed
@SergeiPavlov SergeiPavlov deleted the Deque branch January 15, 2025 21:34
SergeiPavlov added a commit that referenced this pull request Jan 15, 2025
* Get rid of unused `Dequeue<>`

* Make `OperationRegistry` internal
SergeiPavlov added a commit that referenced this pull request Jan 15, 2025
SergeiPavlov added a commit that referenced this pull request Jan 16, 2025
* Make `KeyField` readonly struct (#339)

* Use `FrozenSet`

* .NET compatible syntax

* .NET compatible syntax

* missed static

* EnsureCapacity()

* Fix ValidateHierarchy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants