Allow to assign Node.Name only once to avoid on-change subscriptions overhead#344
Merged
SergeiPavlov merged 7 commits intomaster-servicetitanfrom Jan 16, 2025
Merged
Allow to assign Node.Name only once to avoid on-change subscriptions overhead#344SergeiPavlov merged 7 commits intomaster-servicetitanfrom
Node.Name only once to avoid on-change subscriptions overhead#344SergeiPavlov merged 7 commits intomaster-servicetitanfrom
Conversation
botinko
approved these changes
Jan 16, 2025
snaumenko-st
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dumps show that

Nodes' on-Name-Change subscriptions take > 11MBBut they are not used, because the Domain Model is immutable.
And the App does not use provided API to modify the built model.
In this PR I've added checking to ensure
Node.Nameis allowed to be assigned only once to non-null value.It would be better to convert it into
initsetter, but will require massive refactoring.Also:
Nodedoesn't implementIChangeNotifieranymoreNode.Namesetter beinternal