Skip to content

Process ReadOnlySpan<Key> case (appears with .NET 9.0.200 SDK) #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 12, 2025
Merged

Process ReadOnlySpan<Key> case (appears with .NET 9.0.200 SDK) #356

merged 3 commits into from
Feb 12, 2025

Conversation

SergeiPavlov
Copy link
Collaborator

@SergeiPavlov SergeiPavlov commented Feb 12, 2025 •
edited
Loading

This is a follow up of #328

Also add following processing to ExpressionProcessor:

  • Replace ReadOnlySpan<>.Contains() by IEnumerable<>.Contains()
  • Remove implicit casting of T[] into ReadOnlySpan<T>

snaumenko-st
snaumenko-st approved these changes Feb 12, 2025
View reviewed changes
Copy link

@snaumenko-st snaumenko-st left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too hard to understand this stuff

@SergeiPavlov SergeiPavlov merged commit 5166df1 into master-servicetitan Feb 12, 2025
4 checks passed
@SergeiPavlov SergeiPavlov deleted the ReadOnlySpan1 branch February 12, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snaumenko-st snaumenko-st snaumenko-st approved these changes

@botinko botinko Awaiting requested review from botinko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergeiPavlov @snaumenko-st