Limit StorageNode's caches capacity#360
Closed
SergeiPavlov wants to merge 2 commits into
Closed
Conversation
botinko
requested changes
Mar 1, 2025
botinko
left a comment
There was a problem hiding this comment.
IMO not worth exchange static mem to cpu and more allocation in this case. if StorageNode was loaded to cache, it will be used in future with high probability.
Collaborator
Author
Caches themselves are Ok. I'm against unlimited caches. That is direct way to memory leaks Also we always should consider good trading CPU vs RAM. |
snaumenko-st
reviewed
Mar 3, 2025
Collaborator
Author
|
Replaced by #361 |
Collaborator
Author
There are no unmanaged values, so no need for disposing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They were unlimited

ConcurrentDictionaryTypical process may have > 1000
StorageNodes and these caches take significant amount of RAM: