Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate ITrackingItem.RawData == null issue #362

Merged
merged 4 commits into from
Mar 6, 2025

Conversation

SergeiPavlov
Copy link
Collaborator

@SergeiPavlov SergeiPavlov commented Mar 5, 2025

We have an issue during deleting entities from EntitySet:
https://servicetitan.slack.com/archives/CAXMG2939/p1741136254221939?thread_ts=1741133188.886809&cid=CAXMG2939

It is hard to understand what is the cause.
This DO code is pretty old

Let's just not throw an exception if RawData == null

@SergeiPavlov SergeiPavlov requested review from shuruev and botinko March 5, 2025 21:35
Copy link

@shuruev shuruev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're the expert 🙂 so, whatever you say

@SergeiPavlov SergeiPavlov merged commit ea9c6bd into master-servicetitan Mar 6, 2025
4 checks passed
@SergeiPavlov SergeiPavlov deleted the TrackingNRE branch March 6, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants