Refactor UrlInfo into immutable record#363
Merged
SergeiPavlov merged 3 commits intomaster-servicetitanfrom Mar 11, 2025
Merged
Conversation
botinko
reviewed
Mar 8, 2025
botinko
reviewed
Mar 8, 2025
| { | ||
| [DebuggerStepThrough] get; | ||
| set { | ||
| field = value; |
Collaborator
Author
There was a problem hiding this comment.
The URI RFC does not define port limits:
https://www.rfc-editor.org/rfc/rfc3986#section-3.2.3
Yes, for TCP it is 16-bit. But UrlInfo` is considered to be more general
botinko
reviewed
Mar 8, 2025
| { | ||
| [DebuggerStepThrough] get; | ||
| set { | ||
| field = value; |
There was a problem hiding this comment.
validate with current regex pattern and parse logic.
botinko
reviewed
Mar 8, 2025
| { | ||
| [DebuggerStepThrough] get => field; | ||
| set { | ||
| field = value; |
There was a problem hiding this comment.
validate with current regex pattern and parse logic.
botinko
reviewed
Mar 8, 2025
botinko
reviewed
Mar 8, 2025
botinko
approved these changes
Mar 8, 2025
SergeiPavlov
changed the title
UrlInfo into recordUrlInfo into immutable record
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow to modify
UrlInfoproperties by C#withoperator.The
.Url&.ToString()will synchronize with the updated property.The behavior change:
UrlInfo.Paramsis nowSortedDictionaryWithout this the order of parameteres in
.Urlwas non-deterministic.UrlInfoparsed from URLs with different order of parameters are considered as Equal now.