Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose test and subtest counts in scores.json #35

Closed
wants to merge 4 commits into from

Conversation

delan
Copy link
Member

@delan delan commented Nov 8, 2024

No description provided.

mrego added a commit that referenced this pull request Apr 2, 2025
This modifies the scores.json file so it now provides more data:
* total_tests: The total number of tests
* total_score: The total scores for the tests
* per_mille: Per mille value of dividing total_score by total_tests
* total_subtests: The total number of subtests
* total_subtests_passed: The number of subtests that pass
* per_mille_subtests: Per mille value of dividing total_subtests by total_subtests_passed

This is based on previous work by Delan Azabani at #35.

Co-authored-by: Delan Azabani <[email protected]>
Signed-off-by: Manuel Rego Casasnovas <[email protected]>
@mrego
Copy link
Member

mrego commented Apr 2, 2025

Sorry but I only realized about this PR when I have half-done a similar one #56. I don't really mind which one we land, but it'd be useful to have information about subtests in servo.org.

@delan
Copy link
Member Author

delan commented Apr 3, 2025

No worries! I’ll close this in favour of yours :)

@delan delan closed this Apr 3, 2025
mrego added a commit that referenced this pull request Apr 3, 2025
This modifies the scores.json file so it now provides more data:
* total_tests: The total number of tests
* total_score: The total scores for the tests
* per_mille: Per mille value of dividing total_score by total_tests
* total_subtests: The total number of subtests
* total_subtests_passed: The number of subtests that pass
* per_mille_subtests: Per mille value of dividing total_subtests by total_subtests_passed

This is based on previous work by Delan Azabani at #35.

Co-authored-by: Delan Azabani <[email protected]>
Signed-off-by: Manuel Rego Casasnovas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants