Enable overflow:clip for Servo #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longvatrong111
force-pushed
the
overflow-clip
branch
from
860618a to
f54c445
Compare
longvatrong111
changed the title
5 tasks
xiaochengh
reviewed
Jan 21, 2025
Loirooriol
reviewed
Jan 21, 2025
longvatrong111
force-pushed
the
overflow-clip
branch
2 times, most recently
from
301da4f to
607ef34
Compare
longvatrong111
force-pushed
the
overflow-clip
branch
from
607ef34 to
25d6301
Compare
Loirooriol
reviewed
Jan 25, 2025
| "computed::Length::zero()", | ||
| parse_method="parse_non_negative", | ||
| engines="gecko", | ||
| "OverflowClipMargin", |
There was a problem hiding this comment.
I would keep this as a length for now.
If afterwards you want to generalize it, it would be better to do it upstream in Firefox, and then I will sync it into here.
We are trying to minimize the difference with upstream, because otherwise syncing is very tedious.
There was a problem hiding this comment.
Can you check #114?
I'll comeback with visual-box for overflow-clip-margin later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR help
overflow : clipimplementation in Servooverflow : clipfor Servooverflow-clip-marginTest case:
Servo PR: servo/servo#35103
cc: @xiaochengh