Experimental: uses ktor to perform HTTP calls #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in-translations [Automated] Update translations from Crowdin
SES-4107 : Non-voicenote audio attachments are not treated as attachments
SES-3437 : Community Mentions Inconsistent
Fixing store issues
Fix/pro badge qa fixes
SES-4362 : Unread and mention indicators lose their values in RTL
…ovements Fix/qr scanning improvements
…in-translations [Automated] Update translations from Crowdin
…in-translations [Automated] Update translations from Crowdin
…in-translations [Automated] Update translations from Crowdin
# Conflicts: # app/build.gradle # app/src/main/AndroidManifest.xml # app/src/main/java/org/session/libsession/snode/SnodeAPI.kt # app/src/main/java/org/session/libsession/utilities/Util.kt # app/src/main/java/org/thoughtcrime/securesms/ApplicationContext.java # app/src/main/res/xml/network_security_configuration.xml # gradle.properties # libsignal/build.gradle # libsignal/src/main/java/org/session/libsignal/streams/ProfileCipherInputStream.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental PR that tries to replace okhttp with ktor as our main http library.
This is due to the thread model used in okhttp isn't scalable: it's a blocking thread based model. This means that if you happen to have 100 groups you'll likely end up with 100 threads while they are all polling at the same time. If you limit the thread number, all threads will be blocked busy waiting for the http polling and leave no rooms for other operations.
In contrast, ktor/cio uses a selector model which can scale up network concurrency almost limitedlessly(* still subjects to system resources but no threads are created as the number of connection increases).
This PR is here so that people can try out if it makes any significant performance improvement, particularly when you have large number of groups (for a small number of groups it's expected to not have any advantage).
TODO list:
ProfileCipherInputStreamwhere it assumes things about a particular cipher. This "particular cipher" has to be removed so that ktor/tls works.