Some additions to your polyfill. #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a support check so event handlers are only added to fields in browsers that don't support one of the 3 pseudo-classes. Changed which events get listeners for better cross-browser and cross-platform support. Specified the two element types that can have the `placeholder` attribute. Fix the `DOMContentLoaded` event listener, to actually pass it the function instead of the function's result. Added a fix for old Webkit browsers.
Updating the readme to correspond with changes to the script.
Reformatting the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make sure you saw my changes in case you'd like to add them to your code.