Make chair counts easier to understand#911
Draft
saadabdali wants to merge 6 commits into
Draft
Conversation
…on most mobile screens
Contributor
Author
|
One more quick thing:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@beaudrykock-moi - I spent some time exploring the counts.
On the one hand: this is a small change that I think is ultimately more logical than what we have today.
On the other hand: I also feel I actually ought to ask more questions about who the audience for this change is, and what context they're operating in. And that there's a lot more we could provide here if we knew more about that.
What's in this PR
CUSTODYandCAREusers), we replace theIn transitcount with aheldcount.Available,Held, andOccupied. These three numbers are always guaranteed to add up to your online capacity (I'm thinking of online capacity as total capacity, less any chairs markedunavailableOccupiedorunavailableUnoccupiedby an admin).Transittab.Here's what that looks like for

CUSTODY:CAREwill also see the updated Facility card, but they don't have aTransittab, so they don't get that badge.Why we might merge this
The mental model here is clearer, I think:
10 chairs availablein huge font, and then below that, it says2 in transit. Two chairs in transit?Transit,Custody,Released) are workflow-centric, and they cut across the natural chair categories. (Transitis just a subset of held chairs;Custodyincludes both held chairs and occupied chairs; andReleasedincludes some people who are outside the chair accounting.)Why we might want to do something else (instead, or in addition)
CAREusers can no longer see the number of people in transit from the main page. (They can still see it in the detailed breakdown when they clickManage capacity).Transittab header uses more horizontal space, which looks fine on my phones but may exacerbate clipping on phones with enlarged fonts.CARE, don't they already get what they need from the detailed breakdown on themanage-capacitypage? Instead of trying to cram the chair-accounting onto the page header, should we actually offer a full-page, tablet-optimized (rather than phone-optimized) experience? Instead of coarse buckets (held/occupied/available), is it helpful to show a more complete sequence diagram of all the states? In addition to counts, do we actually want to show the underlying Holds in every category? This all depends on who we're imagining the audience for this is, and what they're trying to do.