Fix Bell pair link generation rate#578
Merged
Merged
Conversation
…een photons. Using attosecond as the base unit instead of seconds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the link generation rate is set by
photon_detection_per_secondparameter at BSA.It was not converted properly to the
time_interval_between_photonswhen scheduling photon arrival specified by BSA_Controller due to the division of integers.I fixed this by converting the base unit to attosecond. While it could still result in imprecise actual rate, as long as the division into attosecond (using long long) is close enough, it should not be a problem.
This fixes #562.
This change is