Skip to content

fix: remove unreachable duplicate if-else branch in RuleEngine #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tanapatnamsomboon wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove unreachable duplicate if-else branch in RuleEngine #580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions quisp/modules/QRSA/RuleEngine/RuleEngine.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,18 +167,6 @@ void RuleEngine::handleMessage(cMessage *msg) {
RuleSet ruleset(0, 0);
ruleset.deserialize_json(serialized_ruleset);
runtimes.acceptRuleSet(ruleset.construct());
} else if (auto *pkt = dynamic_cast<InternalRuleSetForwarding *>(msg)) {
// add actual process
auto serialized_ruleset = pkt->getRuleSet();
RuleSet ruleset(0, 0);
ruleset.deserialize_json(serialized_ruleset);
runtimes.acceptRuleSet(ruleset.construct());
} else if (auto *pkt = dynamic_cast<InternalRuleSetForwarding_Application *>(msg)) {
if (pkt->getApplication_type() != 0) error("This application is not recognized yet");
auto serialized_ruleset = pkt->getRuleSet();
RuleSet ruleset(0, 0);
ruleset.deserialize_json(serialized_ruleset);
runtimes.acceptRuleSet(ruleset.construct());
} else if (auto *pkt = dynamic_cast<StopEmitting *>(msg)) {
handleStopEmitting(pkt);
}
Expand Down