add 2.5D WFS reference contour examples #184
Open
+207
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the examples are now here: |
mgeier
reviewed
Aug 30, 2025
- add two examples for xref(x0) reference contour into docstring
- use wavelength instead of frequency (which assumed c=343 m/s) - use array2 with N=64, does the job and looks nicer - now avoids 'hard coded' wording, but gives a hint for code validity - x0_ -> x0_tmp, xs_ -> xs_tmp
- use f_tmp / omega_tmp for the two ref contour examples only
- more convenient to have this in a notebbok - the wfs.py examples remain minimal and straightforward - the proposed notebook can be extended to referencing schemes for linear SSDs and in general for other potential referencing schemes
- remove array2 as not needed for the new proposal
lmb -> wavelength
explicite marker and linestyle
change negative x-axis to x-axis
fs446
force-pushed
the
add_wfs_point_25d_fd_examples
branch
from
5394090 to
4cdbb56
Compare
- nicer code structure, format - subplot(2,1) instead of (1,2) seems nicer - scatter plot for ref contour - tapering not needed - add difference as magnitude plot
mgeier
reviewed
Sep 2, 2025
| "source": [ | ||
| "# WFS Referencing Schemes\n", | ||
| "\n", | ||
| "Illustrates the usage of the SFS toolbox for the simulation of different 2.5D WFS referencing schemes for contours within the listening area that exhibit amplitude correct synthesis, cf. Ch. 4.1.3 in <cite data-cite=\"Firtha2019\">[Firtha19]</cite> and <cite data-cite=\"Firtha2017\">(FFSS17)</cite>." |
There was a problem hiding this comment.
Suggested change
| "Illustrates the usage of the SFS toolbox for the simulation of different 2.5D WFS referencing schemes for contours within the listening area that exhibit amplitude correct synthesis, cf. Ch. 4.1.3 in <cite data-cite=\"Firtha2019\">[Firtha19]</cite> and <cite data-cite=\"Firtha2017\">(FFSS17)</cite>." | |
| "Illustrates the usage of the SFS toolbox for the simulation of different 2.5D WFS referencing schemes for contours within the listening area that exhibit amplitude correct synthesis, cf. Ch. 4.1.3 in <cite data-cite=\"Firtha2019\">[Firtha19]</cite> and <cite data-cite=\"Firtha2017\">[FFSS17]</cite>." |
It would probably simplify maintenance to make the BibTeX key the same as what is displayed?
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "xs = sfs.util.asarray_of_rows((-4, 0, 0))\n", |
There was a problem hiding this comment.
Suggested change
| "xs = sfs.util.asarray_of_rows((-4, 0, 0))\n", | |
| "xs = sfs.util.asarray_of_rows(xs)\n", |
| "source": [ | ||
| "### Line as reference contour\n", | ||
| "\n", | ||
| "The reference contour is calculated according to <cite data-cite=\"Firtha2017\">(FFSS17)</cite> for a virtual point source on x-axis." |
There was a problem hiding this comment.
Suggested change
| "The reference contour is calculated according to <cite data-cite=\"Firtha2017\">(FFSS17)</cite> for a virtual point source on x-axis." | |
| "The reference contour is calculated according to <cite data-cite=\"Firtha2017\">[FFSS17]</cite> for a virtual point source on x-axis." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.