Skip to content

Conversation

@FlamingoPg
Copy link
Collaborator

Motivation

Upd sgl-kernel cauz DeepGEMM DSA kernel.
sgl-project/DeepGEMM#13

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @FlamingoPg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine version bump for the sgl-kernel library, advancing it from version 0.3.13 to 0.3.14. The primary purpose of this update is to incorporate recent enhancements and fixes, particularly those stemming from the DeepGEMM project's DSA kernel. This ensures that the sgl-kernel package remains current with its dependencies and leverages the latest performance improvements.

Highlights

  • Version Bump: The sgl-kernel package version has been updated from 0.3.13 to 0.3.14 across all relevant configuration and version files.
  • DeepGEMM Integration: This version update is specifically motivated by the integration of changes related to the DeepGEMM DSA kernel, as indicated in the pull request description.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the version of sgl-kernel to 0.3.14. The version number is updated in four separate files. While the changes are correct, this approach of manually updating the version in multiple locations is error-prone and can lead to inconsistencies. My review provides suggestions to centralize the version management by using a single source of truth (python/sgl_kernel/version.py) and configuring the pyproject.toml files to dynamically read the version from it. This will improve the maintainability of the project.

@zhyncs zhyncs self-assigned this Sep 29, 2025
@zhyncs
Copy link
Member

zhyncs commented Sep 30, 2025

Cool! Thanks for this great work! cc @fzyzcjy @DarkSharpness @hnyls2002

@zhyncs
Copy link
Member

zhyncs commented Sep 30, 2025

@fzyzcjy
Copy link
Collaborator

fzyzcjy commented Sep 30, 2025

looks great, I have verified the indexer inside public deepgemm can also be used without any change to the dsv32 branch, thus expect this 0.3.14 can be used easily

@zhyncs
Copy link
Member

zhyncs commented Sep 30, 2025

cool @fzyzcjy may you use this whl to verify https://github.com/sgl-project/sglang/actions/runs/18112446880?pr=11067 thanks!

@zhyncs
Copy link
Member

zhyncs commented Sep 30, 2025

HOLD ON, DON'T MERGE THIS

@fzyzcjy
Copy link
Collaborator

fzyzcjy commented Sep 30, 2025

I can confirm it works well after following yinfan's change to from . import deep_gemm_cpp

image

@zhyncs zhyncs merged commit 580051c into sgl-project:main Sep 30, 2025
26 of 59 checks passed
@fzyzcjy
Copy link
Collaborator

fzyzcjy commented Sep 30, 2025

@zhyncs wait a minute, is the from . import deep_gemm_cpp updated or not? I only did local change as a hack yinfan suggests

@FlamingoPg
Copy link
Collaborator Author

@zhyncs wait a minute, is the from . import deep_gemm_cpp updated or not? I only did local change as a hack yinfan suggests

sgl-project/DeepGEMM@b0ab8bc

@fzyzcjy
Copy link
Collaborator

fzyzcjy commented Sep 30, 2025

looks great

@zhyncs
Copy link
Member

zhyncs commented Sep 30, 2025

cool!

ch-tiger1 pushed a commit to ch-tiger1/sglang that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants