-
Notifications
You must be signed in to change notification settings - Fork 3.3k
chore: bump sgl-kernel v0.3.14 #11067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @FlamingoPg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine version bump for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request bumps the version of sgl-kernel to 0.3.14. The version number is updated in four separate files. While the changes are correct, this approach of manually updating the version in multiple locations is error-prone and can lead to inconsistencies. My review provides suggestions to centralize the version management by using a single source of truth (python/sgl_kernel/version.py) and configuring the pyproject.toml files to dynamically read the version from it. This will improve the maintainability of the project.
|
Cool! Thanks for this great work! cc @fzyzcjy @DarkSharpness @hnyls2002 |
|
looks great, I have verified the indexer inside public deepgemm can also be used without any change to the dsv32 branch, thus expect this 0.3.14 can be used easily |
|
cool @fzyzcjy may you use this whl to verify https://github.com/sgl-project/sglang/actions/runs/18112446880?pr=11067 thanks! |
|
HOLD ON, DON'T MERGE THIS |
|
@zhyncs wait a minute, is the |
|
|
looks great |
|
cool! |

Motivation
Upd sgl-kernel cauz DeepGEMM DSA kernel.
sgl-project/DeepGEMM#13
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist