Skip to content

Conversation

@mickqian
Copy link
Collaborator

@mickqian mickqian commented Dec 5, 2025

And:

  1. some very small refactors
  2. testcase resuming

Motivation

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

@mickqian mickqian requested a review from yhyang201 as a code owner December 5, 2025 03:12
@gemini-code-assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-actions github-actions bot added the diffusion SGLang Diffusion label Dec 5, 2025
@mickqian
Copy link
Collaborator Author

mickqian commented Dec 5, 2025

/tag-and-rerun-ci

@github-actions github-actions bot added the run-ci label Dec 5, 2025
@mickqian mickqian changed the title [diffusion] chore: minor cleanups [diffusion] chore: invert default value for override_protected_fields Dec 5, 2025
@mickqian mickqian changed the title [diffusion] chore: invert default value for override_protected_fields [diffusion] chore: set true as default value for override_protected_fields Dec 5, 2025
@mickqian mickqian changed the title [diffusion] chore: set true as default value for override_protected_fields [diffusion] chore: set allowing overriding protected fields of sampling params as default behavior Dec 5, 2025
@mickqian mickqian merged commit a890456 into main Dec 5, 2025
46 of 47 checks passed
@mickqian mickqian deleted the diffusion-refactor branch December 5, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

diffusion SGLang Diffusion run-ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants