-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[Feature] Support file:// URL format for multimodal inputs #14490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @ppraneth, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for file:// URL formats for multimodal inputs, which is a valuable feature. The changes in load_image and get_image_bytes are well-implemented. However, in load_video, the logic for handling file paths is a bit redundant and inconsistent. I've provided a suggestion to refactor this part to improve clarity and maintainability.
| elif video_file.startswith("file://"): | ||
| video_file = unquote(urlparse(video_file).path) | ||
| vr = VideoReader(video_file, ctx=ctx) | ||
| # `urlparse` supports file:// paths, and so does VideoReader | ||
| elif os.path.isfile(urlparse(video_file).path): | ||
| elif os.path.isfile(unquote(urlparse(video_file).path)): | ||
| vr = VideoReader(video_file, ctx=ctx) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic for handling local file paths and file:// URIs can be simplified. The two elif blocks are redundant and can be combined into a single, more robust check. This also resolves the inconsistency where one branch modifies video_file and the other doesn't, and it makes it clear that a plain file path is always passed to VideoReader.
The comment on line 956 also appears to be incorrect with the new logic, as the path is extracted from file:// URIs before being passed to VideoReader.
| elif video_file.startswith("file://"): | |
| video_file = unquote(urlparse(video_file).path) | |
| vr = VideoReader(video_file, ctx=ctx) | |
| # `urlparse` supports file:// paths, and so does VideoReader | |
| elif os.path.isfile(urlparse(video_file).path): | |
| elif os.path.isfile(unquote(urlparse(video_file).path)): | |
| vr = VideoReader(video_file, ctx=ctx) | |
| # Handle local file paths, including file:// URIs | |
| elif os.path.isfile(parsed_path := unquote(urlparse(video_file).path)): | |
| vr = VideoReader(parsed_path, ctx=ctx) |
Motivation
Currently, the OpenAI server URL only supports standard path formats and does not accept URLs prefixed with
file://. vLLM already supports this input format. This PR adds support forfile://URL formats in image and video loading functions, enablingsglangto handle local file URLs properly.Modifications
load_image,get_image_bytes, andload_videoinsglang/srt/utils/common.pyto explicitly handle thefile://prefix usingurllib.parse.urlparse.file://URL and pass it to the underlying loading functions (Image.open,open,VideoReader).Resolves #14479
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist