Skip to content

Conversation

@yctseng0211
Copy link
Contributor

Motivation

The interface of fused_rms_mxfp4_quant should be changed once aiter upgraded

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @yctseng0211, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on adapting the codebase to an upgraded version of AITemplate. It updates the AITemplate commit reference in the Docker build configuration and adjusts the interface of the "fused_rms_mxfp4_quant" function within the DeepSeek-V2 model's implementation to maintain compatibility with the new AITemplate version.

Highlights

  • AITemplate Version Upgrade: The AITemplate commit version referenced in the Dockerfile has been updated from "v0.1.7.post2" to "v0.1.7.post4" to align with newer AITemplate developments.
  • Fused RMS Interface Adjustment: The call to the "fused_rms_mxfp4_quant" function in the DeepSeek-V2 model's implementation was modified to accommodate a change in its return signature, specifically by adding an underscore "_" to capture an additional, now unused, return value.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@yctseng0211 yctseng0211 changed the title [AMD] change fused rms interface for aiter upgrade [AMD] change fused rms quant interface for aiter upgrade Dec 5, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the aiter dependency to v0.1.7.post4 and adapts the code to a change in the fused_rms_mxfp4_quant function's interface. The modification in python/sglang/srt/models/deepseek_v2.py correctly adjusts the tuple unpacking to accommodate the new return signature. The changes are consistent and look correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant