Skip to content

[Sglang] Update P2P RDMA weight sync with flashinfer compatibility and NIC affinity#22468

Open
wduan-hai wants to merge 1 commit intosgl-project:mainfrom
wduan-hai:wduan/p2p-flashinfer-restore
Open

[Sglang] Update P2P RDMA weight sync with flashinfer compatibility and NIC affinity#22468
wduan-hai wants to merge 1 commit intosgl-project:mainfrom
wduan-hai:wduan/p2p-flashinfer-restore

Conversation

@wduan-hai
Copy link
Copy Markdown
Contributor

@wduan-hai wduan-hai commented Apr 9, 2026

Motivation

Update P2P RDMA weight sync with flashinfer compatibility and NIC affinity. This works in tandem with radixark/miles#964 and is miles 964's dependency.

Modifications

NIC affinity: we allow a manual json flag --remote-instance-weight-loader-ib-device to be passed from miles to sglang, so each GPU can find its NIC during the P2P RDMA weight sync.

Flashinfer compatibility: The P2P RDMA sync is 3 steps, first pre process, then weight transfer, and then post process. We add a trigger in pre process such that the 4D tensor of gate_up is transformed to the 3D format before the weight transfer, to be consistent with the format from the miles side. After the weight transfer, the post process will shape it back. Without the reshape in pre processing, the check equality fails.

Accuracy Tests

Tested on 4 node with Qwen3-30B-A3B, 16 node with Qwen3-235B-A22B over RoCE.

Speed Tests and Profiling

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-actions github-actions bot added the quant LLM Quantization label Apr 9, 2026
JD-ETH added a commit to JD-ETH/sglang that referenced this pull request Apr 14, 2026
…ffinity

Enables specifying IB devices for P2P RDMA weight transfer via Mooncake
TransferEngine. Supports single device, comma-separated list, JSON
per-GPU mapping, or JSON file path. This allows each GPU to use its
nearest NIC, reducing per-HCA memory registration pressure.

Cherry-picked from sgl-project#22468 (NIC affinity parts only).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

quant LLM Quantization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant