[codex] diffusion: expose ERNIE use_pe CLI option#23091
Closed
BBuf wants to merge 1 commit intosgl-project:mainfrom
Closed
[codex] diffusion: expose ERNIE use_pe CLI option#23091BBuf wants to merge 1 commit intosgl-project:mainfrom
BBuf wants to merge 1 commit intosgl-project:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
ce3ac69 to
015ae65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Expose ERNIE's per-request
use_pesampling parameter through the sharedsglang generateCLI as--use-pe.Why
ErnieImageSamplingParamsalready hasuse_pe, but one-off CLI runs could not set it without a config file. This makessglang generate ... --use-pe falsework directly while preserving the model default.H100 Perf
Benchmark: H100 80GB, ERNIE-Image-Turbo, 512x512, 10 steps,
use_pe=false, warmup enabled, native SGLang backend. Before uses the config-file workaround; after uses the new CLI flag. Perf JSON is committed underdocs/assets/benchmarks/ernie_use_pe_cli/.Result Images
Before:
After:
Checks
PYTHONPATH=python pytest -q python/sglang/multimodal_gen/test/unit/test_sampling_params.py -k 'ernie_image_cli_path or qwen_image_cli_path or get_cli_args'-> 6 passedsglang generate --use-pe falseERNIE-Image-Turbo, saved image and perf JSON