Skip to content

Conversation

@lifuhuang
Copy link
Collaborator

Motivation

Quick follow up from #6494

Idefics2 is a vision model produced by HuggingFace, which is shared by both MiniCPMV, Phi4MM, and many other VLMs.
Currently Phi4MM is taking an incorrect dependency on MiniCPMV module, only because Idefics2 was placed there.

Modifications

  • Extract Idefics from MiniCPMV into a separate module to remove.
  • Add file headers to phi4mm following SGL convention.

Checklist

@zhyncs zhyncs merged commit 79a39ac into sgl-project:main May 27, 2025
0 of 36 checks passed
Layssy pushed a commit to Layssy/sglang-iaas that referenced this pull request Jun 9, 2025
xwu-intel pushed a commit to xwu-intel/sglang that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants