Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disabled button on save and before any changes, handled errors #270

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: disabled button on save and before any changes, handled errors #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions components/editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@ interface EditorProps {
type FormData = z.infer<typeof postPatchSchema>

export function Editor({ post }: EditorProps) {
const { register, handleSubmit } = useForm<FormData>({
const { register, handleSubmit, formState: {errors, isSubmitting, isDirty} } = useForm<FormData>({
resolver: zodResolver(postPatchSchema),
})
const ref = React.useRef<EditorJS>()
const router = useRouter()
const [isSaving, setIsSaving] = React.useState<boolean>(false)
const [isMounted, setIsMounted] = React.useState<boolean>(false)
const [editorContentChanged, setEditorContentChanged] = React.useState<boolean>(false);

const initializeEditor = React.useCallback(async () => {
const EditorJS = (await import("@editorjs/editorjs")).default
Expand All @@ -50,6 +50,9 @@ export function Editor({ post }: EditorProps) {
onReady() {
ref.current = editor
},
onChange: () => {
setEditorContentChanged(true);
},
placeholder: "Type here to write your post...",
inlineToolbar: true,
data: body.content,
Expand Down Expand Up @@ -84,7 +87,6 @@ export function Editor({ post }: EditorProps) {
}, [isMounted, initializeEditor])

async function onSubmit(data: FormData) {
setIsSaving(true)

const blocks = await ref.current?.save()

Expand All @@ -99,8 +101,6 @@ export function Editor({ post }: EditorProps) {
}),
})

setIsSaving(false)

if (!response?.ok) {
return toast({
title: "Something went wrong.",
Expand Down Expand Up @@ -138,8 +138,8 @@ export function Editor({ post }: EditorProps) {
{post.published ? "Published" : "Draft"}
</p>
</div>
<button type="submit" className={cn(buttonVariants())}>
{isSaving && (
<button disabled={isSubmitting || !(isDirty || editorContentChanged)} type="submit" className={cn(buttonVariants())}>
{isSubmitting && (
<Icons.spinner className="mr-2 h-4 w-4 animate-spin" />
)}
<span>Save</span>
Expand All @@ -154,6 +154,9 @@ export function Editor({ post }: EditorProps) {
className="w-full resize-none appearance-none overflow-hidden bg-transparent text-5xl font-bold focus:outline-none"
{...register("title")}
/>
{errors.title && (
<p className="text-red-500">{`${errors.title.message}`}</p>
)}
<div id="editor" className="min-h-[500px]" />
<p className="text-sm text-gray-500">
Use{" "}
Expand Down
2 changes: 1 addition & 1 deletion lib/validations/post.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as z from "zod"

export const postPatchSchema = z.object({
title: z.string().min(3).max(128).optional(),
title: z.string().min(3, "Title must be at least 3 characters long").max(128).optional(),

// TODO: Type this properly from editorjs block types?
content: z.any().optional(),
Expand Down