fix(cli): detect vinxi-based frameworks (@tanstack/start, SolidStart, ...) #6330
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KitsuneDev is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CLI support for vinxi-based projects, such as @tanstack/start and Solid Start.
Thanks to the fact that those projects are essentially Vite projects, not many changes were necessary, and adding the
app.config.*to the detection logic is all that was really necessary. Just to be on the safe side, I also added a simple check that the said file does contain adefineConfigstring (and is actually a Vinxi-based config), as the nameapp.config.*tends to be quite generic.This has been tested in a barebones @tanstack/start project, and the result can be viewed here. Each commit represents a step of the setup process, following the instructions from the docs.