Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CommonJS to js-deps table. #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

quangv
Copy link
Contributor

@quangv quangv commented Apr 12, 2018

Hey, I thought the ES6 modules import -> CLJS require, was pretty cool!

My mind still thinks of old school node.js require(). Added CommonJS. Not sure if it belongs (and I think I got the statements right).

@thheller
Copy link
Contributor

This seems weird to me? Why are you using ES6 const/destructuring but require?

@quangv
Copy link
Contributor Author

quangv commented Apr 12, 2018

I have not thoroughly tested it. But it looks right 😃

I think adding CommonJS to the table is useful, but maybe it doesn't belong. (Also another downside is the width is now 33.33%)

@thheller
Copy link
Contributor

I wouldn't mind adding this but I feel like there isn't enough room on the page for 3 columns. All lines break which makes this harder to follow I think. No idea how else to format it though.

@quangv
Copy link
Contributor Author

quangv commented Apr 13, 2018

how about a link, (ideally a popup), but maybe just to another page somewhere.

I was trying to look for a "conversion table", from CommonJS to ES6-Imports (to make sure I had it right), but couldn't find one... so it might be a good point of reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants