texture_cache: Do not overwrite overlap hit with a miss. #2217
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
omg squidwars are back again! |
|
i checked this with Red Dead Redemption and it always crashes ingame a bit before starting the first mission with this log error |
|
Marking as draft, I think this should actually already be solved but is creating and returning the wrong image for some reason. |
squidbus
changed the title
|
This should be correct now. |
It doesn't crash anymore 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resolving overlaps, don't overwrite an overlap hit with a miss.
Fixes fog effect in battles in CUSA16404 incorrectly covering the entire screen. The depth buffer was not being matched and instead a new, empty color image was being created.