Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork detection: Fix Windows naming + add a new check for fork detection #2321

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kalaposfos13
Copy link
Contributor

I saw some screenshots on Discord which had the shadps4-emu/main text instead of just main in the window title, and I think this might be due to Windows handling Git remote links slightly differently, so I changed the code to first extract the name, and then check only that, instead of the full link. I don't actually know if this will fix the issue, but I certainly hope it will.
image
I also found a possible reason as to why @StevenMiller123's local builds fail to find the remote link even though his push defaults were set, and it is now included as the second thing to check if the branch doesn't explicitly have a remote pair defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant