Skip to content

fix: Auto-remove default gem files to prevent installer conflicts #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
+1 −1
Open

fix: Auto-remove default gem files to prevent installer conflicts #1848

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fa6e145
fix: Auto-remove default gem files to prevent installer conflicts
justin808 Oct 6, 2025
02cdc82
fix: Improve file deletion safety and robustness
justin808 Oct 7, 2025
ff74a0a
refactor: Extract bin/dev comparison into separate method
justin808 Oct 7, 2025
1ccf5d7
fix: Only remove default files when Shakapacker pre-exists
justin808 Oct 7, 2025
2a78c8a
fix: Check Shakapacker status before installation, remove files after
justin808 Oct 8, 2025
1d39a02
fix: Use destination_root for Gemfile path in generator
justin808 Oct 8, 2025
0281811
Revert "Auto-remove default gem files" feature
justin808 Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/generators/react_on_rails/install_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def shakapacker_in_bundler_specs?(gem_name)
end

def shakapacker_in_gemfile_text?(gem_name)
gemfile = ENV["BUNDLE_GEMFILE"] || "Gemfile"
gemfile = ENV["BUNDLE_GEMFILE"] || File.join(destination_root, "Gemfile")

File.file?(gemfile) &&
File.foreach(gemfile).any? { |l| l.match?(/^\s*gem\s+['"]#{Regexp.escape(gem_name)}['"]/) }
Expand Down
Loading