Skip to content

fix: handle blob URL downloads for history CSV export #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xApotheosis wants to merge 1 commit into
base: main
Choose a base branch
from
+112 −0
Open

fix: handle blob URL downloads for history CSV export #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,13 @@
"expo-constants": "~18.0.9",
"expo-dev-client": "^6.0.17",
"expo-device": "~8.0.9",
"expo-file-system": "~19.0.21",
Copy link

@coderabbitai coderabbitai bot Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

expo-file-system expo-sharing compatibility Expo SDK 54

💡 Result:

Short answer: expo-file-system had breaking API changes in Expo SDK 54 (the "next" rewrite became the default and the old API is available as expo-file-system/legacy). expo-sharing remains compatible with SDK 54 (no breaking changes called out).

Details and actions:

  • Expo SDK 54 made the new expo-file-system API the default; if your code (or libraries you depend on) expect the old API, switch imports to expo-file-system/legacy (or migrate to the new API). [1]
  • Some helpers/APIs were moved/changed (examples: some methods were moved to legacy and others behave differently — e.g. getContentUriAsync/other legacy APIs are available under the legacy package). Check and update any code that uses removed/renamed methods. [2]
  • expo-sharing has no SDK‑54-specific breaking notes in the changelog and its docs remain the same; it should continue to work on SDK 54. [3]

If you want, tell me whether you’re upgrading an app or a library and I’ll suggest the exact import changes or search your package.json for affected packages.

Sources: [1] Expo SDK 54 changelog; [2] github issues about expo-file-system in SDK 54; [3] expo-sharing docs.

🌐 Web query:

Expo SDK 54 dependencies compatibility matrix

💡 Result:

Here’s a concise compatibility summary for Expo SDK 54 (key dependencies, platform/tooling, and important notes):

  • Expo package: expo@^54.0.0. [1]
  • React Native: 0.81 (Expo SDK 54 includes RN 0.81). [1]
  • React: 19.1. [1]
  • iOS toolchain: Xcode 26 recommended / required for iOS 26 features; Expo Go/EAS will use Xcode 26 for SDK 54. [1]
  • Android target: Android 16 / API 36 (edge-to-edge enabled by default). [1]
  • iOS runtime: React Native shipped as precompiled XCFrameworks (affects builds when using use_frameworks!). [1]
  • Autolinking / native modules: updated autolinking behavior (React Native modules installed transitively are autolinked); see autolinking flags in app/package.json if you need legacy behavior. Run npx expo-modules-autolinking verify -v or expo-doctor to check native modules. [1]
  • Upgrade/install helper: use npx expo install --fix and follow the upgrade guide (npm/yarn/pnpm/bun installs of expo@^54.0.0). Run npx expo-doctor after upgrading. [2]
  • Migration caveats: many third‑party libs required updates (Reanimated, worklets, NativeWind, mmkv, etc.); check library changelogs and the Expo GitHub issues if you hit build/runtime errors. [1][3]

Sources:

  • Expo SDK 54 release notes / changelog. [1]
  • Expo upgrade walkthrough (how to upgrade and use npx expo install --fix / expo-doctor). [2]
  • Selected Expo SDK 54 issues / community reports (third‑party compatibility notes). [3]

If you want, I can generate a more detailed matrix listing specific Expo module package versions (expo-constants, expo-file-system, reanimated, react-native-screens, etc.) pulled from the SDK 54 bundled modules. Which exact packages would you like included?

🌐 Web query:

expo-file-system 19.0.21 Expo SDK 54

💡 Result:

Short answer: Expo SDK 54 ships with expo-file-system v19 (bundled ~19.0.21). The package’s new API is now the default; the old API is available under expo-file-system/legacy if you need it. Install with npx expo install expo-file-system and update imports (or use /legacy). [1][2]

Sources:

  • Expo SDK 54 changelog (notes about expo-file-system/new vs legacy). [1]
  • Expo FileSystem SDK 54 reference (bundled version ~19.0.21; install instructions). [2]

Review code using expo-file-system for Expo SDK 54 breaking changes.

expo-file-system ~19.0.21 is compatible with Expo SDK 54 but includes breaking API changes: the new API became the default, and the old API is available under expo-file-system/legacy. Verify that your code uses the correct API or update imports to expo-file-system/legacy if needed.

expo-sharing ~14.0.8 is fully compatible with SDK 54 with no breaking changes.

🤖 Prompt for AI Agents 
In @package.json around line 30, The package.json pins "expo-file-system" to
~19.0.21 which shipped breaking API changes for Expo SDK 54; audit all imports
of "expo-file-system" (search for import statements referencing
expo-file-system) and either migrate call sites to the new API surface in v19 or
change imports to "expo-file-system/legacy" where you need the old behavior,
then update any affected functions (e.g.,
readAsStringAsync/writeAsStringAsync/fileSystem constants) to match the chosen
API; ensure tests/build run after switching to confirm there are no unresolved
API mismatches.

"expo-haptics": "^15.0.7",
"expo-local-authentication": "~17.0.7",
"expo-navigation-bar": "~5.0.8",
"expo-notifications": "~0.32.12",
"expo-secure-store": "~15.0.7",
"expo-sharing": "~14.0.8",
"expo-splash-screen": "~31.0.10",
"expo-status-bar": "^3.0.8",
"expo-store-review": "~9.0.8",
Expand Down
54 changes: 54 additions & 0 deletions src/lib/download.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
/**
* Injected JavaScript to intercept blob URL creation for file downloads.
* When the web app creates a blob URL for a downloadable file (like CSV export),
* this script converts the blob to base64 and sends it to the native app
* via postMessage for proper file handling using expo-file-system and expo-sharing.
*/
export const injectedJavaScript = `
;(function() {
const originalCreateObjectURL = URL.createObjectURL;
URL.createObjectURL = function(blob) {
const url = originalCreateObjectURL.call(URL, blob);

// Check if this is a downloadable file type
const downloadableTypes = [
'text/csv',
'application/csv',
'application/octet-stream',
'text/plain',
'application/json'
];

if (blob instanceof Blob && downloadableTypes.includes(blob.type)) {
const reader = new FileReader();
reader.onloadend = function() {
if (reader.result && typeof reader.result === 'string') {
const base64 = reader.result.split(',')[1];
if (base64 && window.ReactNativeWebView) {
// Determine filename and extension based on MIME type
const mimeToExt = {
'text/csv': '.csv',
'application/csv': '.csv',
'application/json': '.json',
'text/plain': '.txt',
'application/octet-stream': '.csv' // Default to CSV for history export
};
const ext = mimeToExt[blob.type] || '.csv';
const filename = 'transaction-history' + ext;

window.ReactNativeWebView.postMessage(JSON.stringify({
cmd: 'downloadFile',
data: base64,
filename: filename,
mimeType: blob.type || 'application/octet-stream'
}));
}
}
};
reader.readAsDataURL(blob);
}

return url;
};
})();
`
29 changes: 29 additions & 0 deletions src/lib/getMessageManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
/* Register message handlers and injected JavaScript */
import * as Clipboard from 'expo-clipboard'
import { File as ExpoFile, Paths } from 'expo-file-system'
import * as Sharing from 'expo-sharing'
import once from 'lodash.once'
import { injectedJavaScript as injectedJavaScriptClipboard } from './clipboard'
import { injectedJavaScript as injectedJavaScriptDownload } from './download'
import * as StoreReview from 'expo-store-review'
import * as Application from 'expo-application'

Expand Down Expand Up @@ -32,6 +35,9 @@ export const getMessageManager = once(() => {
console.log('[App] Injecting clipboard JavaScript')
messageManager.registerInjectedJavaScript(injectedJavaScriptClipboard)

console.log('[App] Injecting download JavaScript')
messageManager.registerInjectedJavaScript(injectedJavaScriptDownload)

const walletManager = getWalletManager()

messageManager.on('console', onConsole)
Expand All @@ -56,6 +62,29 @@ export const getMessageManager = once(() => {
// clipboard
messageManager.on('setClipboard', evt => Clipboard.setStringAsync(evt.key))

// file download/sharing
messageManager.on('downloadFile', async evt => {
try {
const { data, filename, mimeType } = evt as unknown as {
data: string
filename: string
mimeType: string
}

const file = new ExpoFile(Paths.cache, filename)
file.write(data, { encoding: 'base64' })

if (await Sharing.isAvailableAsync()) {
await Sharing.shareAsync(file.uri, { mimeType })
}

return { success: true }
} catch (error) {
console.error('[downloadFile:Error]', error)
return { success: false, error: String(error) }
}
})

// expo token for push notifications
messageManager.on('getExpoToken', async () => {
try {
Expand Down
6 changes: 6 additions & 0 deletions src/lib/navigationFilter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,12 @@ export const shouldLoadFilter = (request: ShouldStartLoadRequest) => {
return true
}

// Handle blob URLs - these are handled by injected JavaScript in download.ts
// which intercepts URL.createObjectURL and sends file data via postMessage
if (request.url.startsWith('blob:')) {
return false
}

// External navigation
openBrowser(request.url).catch(r => {
console.error(`rejection opening in browser url "${request.url}": `, r)
Expand Down
21 changes: 21 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10458,6 +10458,16 @@ __metadata:
languageName: node
linkType: hard

"expo-file-system@npm:~19.0.21":
version: 19.0.21
resolution: "expo-file-system@npm:19.0.21"
peerDependencies:
expo: "*"
react-native: "*"
checksum: 26b4c95c8d30580723995bf8e32287b72eadf0e3442ca14854c15dc47021c4c22eefbc490ab4fadf98b3f0b14847eba3012dfe663c8a8b42de7b1587f6811d8f
languageName: node
linkType: hard

"expo-font@npm:~14.0.9":
version: 14.0.9
resolution: "expo-font@npm:14.0.9"
Expand Down Expand Up @@ -10598,6 +10608,15 @@ __metadata:
languageName: node
linkType: hard

"expo-sharing@npm:~14.0.8":
version: 14.0.8
resolution: "expo-sharing@npm:14.0.8"
peerDependencies:
expo: "*"
checksum: 8ac54d82328141dc67add5b9db3f16253b42e0e0aa2d39589fffd4d9cf15067e10262b0ab21837b184caae2799de81d74f8b2d129886c50e25550ef4fc6919f3
languageName: node
linkType: hard

"expo-splash-screen@npm:~31.0.10":
version: 31.0.10
resolution: "expo-splash-screen@npm:31.0.10"
Expand Down Expand Up @@ -16520,11 +16539,13 @@ __metadata:
expo-constants: ~18.0.9
expo-dev-client: ^6.0.17
expo-device: ~8.0.9
expo-file-system: ~19.0.21
expo-haptics: ^15.0.7
expo-local-authentication: ~17.0.7
expo-navigation-bar: ~5.0.8
expo-notifications: ~0.32.12
expo-secure-store: ~15.0.7
expo-sharing: ~14.0.8
expo-splash-screen: ~31.0.10
expo-status-bar: ^3.0.8
expo-store-review: ~9.0.8
Expand Down