feat: route custom token metadata imports through proxy#12040
feat: route custom token metadata imports through proxy#120400xApotheosis wants to merge 2 commits intodevelopfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
NeOMakinG
left a comment
There was a problem hiding this comment.
✅ LGTM — Clean refactoring
Changes:
- Proxy routing — Custom token metadata lookups now go through
api.proxy.shapeshift.cominstead of direct Alchemy calls - Removed committed API keys —
VITE_ALCHEMY_API_KEY,VITE_ALCHEMY_POLYGON_URL,VITE_ALCHEMY_SOLANA_BASE_URLremoved from.env - Centralized chain IDs — New
CUSTOM_TOKEN_IMPORT_SUPPORTED_CHAIN_IDSconstant replaces scattered Alchemy SDK references - CSP updates — Added proxy URL, removed direct Alchemy URLs
Benefits:
- No more client-side API keys
- Centralized monitoring and rate limiting via proxy
- Cleaner code with single source of truth for supported chains
CI passes ✅
🤖 Reviewed by Claude Code
🤖 QABot Test Report✅ 1/1 tests passed
Verified: Custom token metadata now routes through proxy API, committed API keys removed. 📊 Full Report: https://qabot-kappa.vercel.app/runs/27ac5bb7-4fe0-4104-96be-c8a4055b6c6d 🤖 Automated QA by Claude Code |
unchainedfriend to be merged for the proxy to deploy: shapeshift/unchained#1265Description
Route custom token metadata import lookups through
api.proxy.shapeshift.cominstead of direct browser Alchemy/Metaplex calls. The primary motivation is that our Alchemy key is being abused since it's checked into the repo. This PR puts it behind a proxy so the key isn't exposed client-side. The key will be rotated once this PR merges.VITE_ALCHEMY_POLYGON_URLand related config/type referencesIssue (if applicable)
N/A
Risk
Low-medium. This changes how custom token metadata is fetched (proxy vs direct Alchemy calls), but does not affect any on-chain transactions, wallet interactions, or core state management. If the proxy is unavailable, custom token imports would fail to resolve metadata.
No protocols, transaction types, wallets, or contract interactions are affected. This only impacts the custom token import metadata lookup flow.
Testing
Engineering
Operations
Screenshots (if applicable)
N/A