feat: eip1559 fees

package.json

@@ -272,6 +272,35 @@
     "react-dom@^18.2.0": "patch:react-dom@npm%3A18.2.0#./.yarn/patches/react-dom-npm-18.2.0-dd675bca1c.patch"
   },
   "jest": {
-    "resetMocks": false
+    "preset": "ts-jest",
+    "testEnvironment": "node",
+    "testPathIgnorePatterns": [
+      "/node_modules/",
+      ".d.ts",
+      ".js",
+      "__mocks__",
+      "mockData"
+    ],
+    "clearMocks": true,
+    "resetMocks": false,
+    "roots": [
+      "<rootDir>"
+    ],
+    "collectCoverage": false,
+    "setupFiles": [
+      "<rootDir>/.jest/setup.js"
+    ],
+    "moduleNameMapper": {
+      "^@shapeshiftoss\\/([^/ ]+)": [
+        "@shapeshiftoss/$1",
+        "@shapeshiftoss/$1/src"
+      ]
+    },
+    "globals": {
+      "ts-jest": {
+        "sourceMap": true,
+        "isolatedModules": true
+      }
+    }
   }
-}
+}

packages/chain-adapters/src/evm/EvmBaseAdapter.ts

@@ -37,7 +37,6 @@ import type {
 import { ValidAddressResultType } from '../types'
 import {
   chainIdToChainLabel,
-  convertNumberToHex,
   getAssetNamespace,
   toAddressNList,
   toRootDerivationPath,
@@ -548,7 +547,7 @@ export abstract class EvmBaseAdapter<T extends EvmChainId> implements IChainAdap
       const bip44Params = this.getBIP44Params({ accountNumber })
       const txToSign = {
         addressNList: toAddressNList(bip44Params),
-        value: convertNumberToHex(value),
+        value: numberToHex(value),
         to,
         chainId: Number(fromChainId(this.chainId).chainReference),
         data,

packages/unchained-client/src/evm/parser/index.ts

@@ -1,6 +1,5 @@
 import type { AssetId, ChainId } from '@shapeshiftoss/caip'
 import { ASSET_NAMESPACE, ASSET_REFERENCE, ethChainId, toAssetId } from '@shapeshiftoss/caip'
-import { Logger } from '@shapeshiftoss/logger'
 import { BigNumber } from 'bignumber.js'
 import { ethers } from 'ethers'
 
@@ -12,11 +11,6 @@ import type { ParsedTx, SubParser, Tx, TxSpecific } from './types'
 export * from './types'
 export * from './utils'
 
-const logger = new Logger({
-  namespace: ['unchained-client', 'evm', 'parser'],
-  level: process.env.LOG_LEVEL,
-})
-
 export interface TransactionParserArgs {
   chainId: ChainId
   assetId: AssetId
@@ -170,7 +164,6 @@ export class BaseTransactionParser<T extends Tx> {
             case 'BEP721':
               return ASSET_NAMESPACE.bep721
             default:
-              logger.warn(`unsupported asset namespace: ${transfer.type}`)
               return
           }
         })()

src/features/defi/helpers/utils.ts

@@ -1,7 +1,16 @@
 import type { Asset } from '@shapeshiftoss/asset-service'
 import type { AccountId, ChainId } from '@shapeshiftoss/caip'
 import { cosmosChainId, osmosisChainId } from '@shapeshiftoss/caip'
-import { bnOrZero } from 'lib/bignumber/bignumber'
+import type {
+  evm,
+  EvmChainAdapter,
+  EvmChainId,
+  FeeData,
+  FeeDataEstimate,
+} from '@shapeshiftoss/chain-adapters'
+import type { HDWallet } from '@shapeshiftoss/hdwallet-core'
+import { supportsETH } from '@shapeshiftoss/hdwallet-core'
+import { BigNumber, bn, bnOrZero } from 'lib/bignumber/bignumber'
 import { selectPortfolioCryptoPrecisionBalanceByFilter } from 'state/slices/selectors'
 import { store } from 'state/store'
 
@@ -34,3 +43,84 @@ export const canCoverTxFees = ({
 
   return bnOrZero(feeAssetBalanceCryptoHuman).minus(bnOrZero(estimatedGasCryptoPrecision)).gte(0)
 }
+
+export const getFeeDataFromEstimate = ({
+  average,
+  fast,
+}: FeeDataEstimate<EvmChainId>): FeeData<EvmChainId> => ({
+  txFee: BigNumber.max(
+    average.txFee,
+    bnOrZero(bn(fast.chainSpecific.gasPrice).times(average.chainSpecific.gasLimit)),
+  ).toFixed(0), // use worst case average eip1559 vs fast legacy
+  chainSpecific: {
+    gasLimit: average.chainSpecific.gasLimit, // average and fast gasLimit values are the same
+    gasPrice: fast.chainSpecific.gasPrice, // fast gas price since it is underestimated currently
+    maxFeePerGas: average.chainSpecific.maxFeePerGas,
+    maxPriorityFeePerGas: average.chainSpecific.maxPriorityFeePerGas,
+  },
+})
+
+type GetFeesFromFeeDataArgs = {
+  wallet: HDWallet
+  feeData: evm.FeeData
+}
+
+export const getFeesFromFeeData = async ({
+  wallet,
+  feeData: { gasLimit, gasPrice, maxFeePerGas, maxPriorityFeePerGas },
+}: GetFeesFromFeeDataArgs): Promise<evm.Fees & { gasLimit: string }> => {
+  if (!supportsETH(wallet)) throw new Error('wallet has no evm support')
+  if (!gasLimit) throw new Error('gasLimit is required')
+
+  const supportsEip1559 = await wallet.ethSupportsEIP1559()
+
+  // use eip1559 fees if able
+  if (supportsEip1559 && maxFeePerGas && maxPriorityFeePerGas) {
+    return { gasLimit, maxFeePerGas, maxPriorityFeePerGas }
+  }
+
+  // fallback to legacy fees if unable to use eip1559
+  if (gasPrice) return { gasLimit, gasPrice }
+
+  throw new Error('legacy gas or eip1559 gas required')
+}
+
+type BuildAndBroadcastArgs = GetFeesFromFeeDataArgs & {
+  accountNumber: number
+  adapter: EvmChainAdapter
+  data: string
+  to: string
+  value: string
+}
+
+export const buildAndBroadcast = async ({
+  accountNumber,
+  adapter,
+  data,
+  feeData,
+  to,
+  value,
+  wallet,
+}: BuildAndBroadcastArgs) => {
+  const { txToSign } = await adapter.buildCustomTx({
+    wallet,
+    to,
+    accountNumber,
+    value,
+    data,
+    ...(await getFeesFromFeeData({ wallet, feeData })),
+  })
+
+  if (wallet.supportsOfflineSigning()) {
+    const signedTx = await adapter.signTransaction({ txToSign, wallet })
+    const txid = await adapter.broadcastTransaction(signedTx)
+    return txid
+  }
+
+  if (wallet.supportsBroadcast() && adapter.signAndBroadcastTransaction) {
+    const txid = await adapter.signAndBroadcastTransaction({ txToSign, wallet })
+    return txid
+  }
+
+  throw new Error('buildAndBroadcast: no broadcast support')
+}

src/features/defi/providers/fox-farming/components/FoxFarmingManager/Claim/ClaimConfirm.tsx

@@ -70,7 +70,7 @@ export const ClaimConfirm = ({ accountId, assetId, amount, onBack }: ClaimConfir
 
   assertIsFoxEthStakingContractAddress(contractAddress)
 
-  const { claimRewards, getClaimGasData, foxFarmingContract } = useFoxFarming(contractAddress)
+  const { claimRewards, getClaimFeeData, foxFarmingContract } = useFoxFarming(contractAddress)
   const translate = useTranslate()
   const mixpanel = getMixPanel()
   const { onOngoingFarmingTxIdChange } = useFoxEth()
@@ -156,9 +156,9 @@ export const ClaimConfirm = ({ accountId, assetId, amount, onBack }: ClaimConfir
           !(walletState.wallet && feeAsset && feeMarketData && foxFarmingContract && accountAddress)
         )
           return
-        const gasEstimate = await getClaimGasData(accountAddress)
-        if (!gasEstimate) throw new Error('Gas estimation failed')
-        const estimatedGasCrypto = bnOrZero(gasEstimate.average.txFee)
+        const feeData = await getClaimFeeData(accountAddress)
+        if (!feeData) throw new Error('Gas estimation failed')
+        const estimatedGasCrypto = bnOrZero(feeData.txFee)
           .div(`1e${feeAsset.precision}`)
           .toPrecision()
         setCanClaim(true)
@@ -174,7 +174,7 @@ export const ClaimConfirm = ({ accountId, assetId, amount, onBack }: ClaimConfir
     feeAsset.precision,
     feeMarketData,
     feeMarketData.price,
-    getClaimGasData,
+    getClaimFeeData,
     walletState.wallet,
     foxFarmingContract,
   ])

src/features/defi/providers/fox-farming/components/FoxFarmingManager/Deposit/components/Approve.tsx

@@ -68,7 +68,7 @@ export const Approve: React.FC<FoxFarmingApproveProps> = ({ accountId, onNext })
   )
   assertIsFoxEthStakingContractAddress(contractAddress)
 
-  const { allowance, approve, getStakeGasData } = useFoxFarming(contractAddress)
+  const { allowance, approve, getStakeFeeData } = useFoxFarming(contractAddress)
 
   const assets = useAppSelector(selectAssets)
 
@@ -109,9 +109,9 @@ export const Approve: React.FC<FoxFarmingApproveProps> = ({ accountId, onNext })
         maxAttempts: 30,
       })
       // Get deposit gas estimate
-      const gasData = await getStakeGasData(state.deposit.cryptoAmount)
-      if (!gasData) return
-      const estimatedGasCryptoPrecision = bnOrZero(gasData.average.txFee)
+      const feeData = await getStakeFeeData(state.deposit.cryptoAmount)
+      if (!feeData) return
+      const estimatedGasCryptoPrecision = bnOrZero(feeData.txFee)
         .div(bn(10).pow(feeAsset.precision))
         .toPrecision()
       dispatch({
@@ -147,7 +147,7 @@ export const Approve: React.FC<FoxFarmingApproveProps> = ({ accountId, onNext })
     wallet,
     asset,
     approve,
-    getStakeGasData,
+    getStakeFeeData,
     feeAsset.precision,
     onNext,
     assets,

src/features/defi/providers/fox-farming/components/FoxFarmingManager/Deposit/components/Deposit.tsx

@@ -95,8 +95,8 @@ export const Deposit: React.FC<DepositProps> = ({
 
   const {
     allowance: foxFarmingAllowance,
-    getStakeGasData,
-    getApproveGasData,
+    getStakeFeeData,
+    getApproveFeeData,
   } = useFoxFarming(contractAddress)
 
   const feeAssetId = getChainAdapterManager().get(chainId)?.getFeeAssetId()
@@ -132,9 +132,9 @@ export const Deposit: React.FC<DepositProps> = ({
       ): Promise<string | undefined> => {
         if (!assetReference) return
         try {
-          const gasData = await getStakeGasData(deposit.cryptoAmount)
-          if (!gasData) return
-          return bnOrZero(gasData.average.txFee).div(bn(10).pow(feeAsset.precision)).toPrecision()
+          const feeData = await getStakeFeeData(deposit.cryptoAmount)
+          if (!feeData) return
+          return bnOrZero(feeData.txFee).div(bn(10).pow(feeAsset.precision)).toPrecision()
         } catch (error) {
           moduleLogger.error(
             { fn: 'getDepositGasEstimateCryptoPrecision', error },
@@ -180,12 +180,12 @@ export const Deposit: React.FC<DepositProps> = ({
             assets,
           )
         } else {
-          const estimatedGasCryptoBaseUnit = await getApproveGasData()
-          if (!estimatedGasCryptoBaseUnit) return
+          const feeData = await getApproveFeeData()
+          if (!feeData) return
           dispatch({
             type: FoxFarmingDepositActionType.SET_APPROVE,
             payload: {
-              estimatedGasCryptoPrecision: bnOrZero(estimatedGasCryptoBaseUnit.average.txFee)
+              estimatedGasCryptoPrecision: bnOrZero(feeData.txFee)
                 .div(bn(10).pow(feeAsset.precision))
                 .toPrecision(),
             },
@@ -210,14 +210,14 @@ export const Deposit: React.FC<DepositProps> = ({
       feeAsset,
       foxFarmingOpportunity,
       assetReference,
-      getStakeGasData,
+      getStakeFeeData,
       toast,
       translate,
       asset,
       foxFarmingAllowance,
       onNext,
       assets,
-      getApproveGasData,
+      getApproveFeeData,
     ],
   )
 

src/features/defi/providers/fox-farming/components/FoxFarmingManager/Withdraw/components/Approve.tsx

@@ -67,7 +67,7 @@ export const Approve: React.FC<ApproveProps> = ({ accountId, onNext }) => {
 
   assertIsFoxEthStakingContractAddress(contractAddress)
 
-  const { allowance, approve, getUnstakeGasData } = useFoxFarming(contractAddress)
+  const { allowance, approve, getUnstakeFeeData } = useFoxFarming(contractAddress)
   const toast = useToast()
   const assets = useAppSelector(selectAssets)
 
@@ -107,9 +107,9 @@ export const Approve: React.FC<ApproveProps> = ({ accountId, onNext }) => {
         maxAttempts: 30,
       })
       // Get withdraw gas estimate
-      const gasData = await getUnstakeGasData(state.withdraw.lpAmount, state.withdraw.isExiting)
-      if (!gasData) return
-      const estimatedGasCrypto = bnOrZero(gasData.average.txFee)
+      const feeData = await getUnstakeFeeData(state.withdraw.lpAmount, state.withdraw.isExiting)
+      if (!feeData) return
+      const estimatedGasCrypto = bnOrZero(feeData.txFee)
         .div(bn(10).pow(underlyingAsset?.precision ?? 0))
         .toPrecision()
       dispatch({
@@ -145,7 +145,7 @@ export const Approve: React.FC<ApproveProps> = ({ accountId, onNext }) => {
     opportunity,
     wallet,
     approve,
-    getUnstakeGasData,
+    getUnstakeFeeData,
     underlyingAsset?.precision,
     onNext,
     assets,

src/features/defi/providers/fox-farming/components/FoxFarmingManager/Withdraw/components/ExpiredWithdraw.tsx

@@ -70,7 +70,7 @@ export const ExpiredWithdraw: React.FC<ExpiredWithdrawProps> = ({
 
   assertIsFoxEthStakingContractAddress(contractAddress)
 
-  const { getUnstakeGasData, allowance, getApproveGasData } = useFoxFarming(contractAddress)
+  const { getUnstakeFeeData, allowance, getApproveFeeData } = useFoxFarming(contractAddress)
 
   const methods = useForm<WithdrawValues>({ mode: 'onChange' })
 
@@ -108,9 +108,9 @@ export const ExpiredWithdraw: React.FC<ExpiredWithdrawProps> = ({
 
   const getWithdrawGasEstimate = async () => {
     try {
-      const fee = await getUnstakeGasData(amountAvailableCryptoPrecision.toFixed(), true)
-      if (!fee) return
-      return bnOrZero(fee.average.txFee).div(bn(10).pow(feeAsset.precision)).toPrecision()
+      const feeData = await getUnstakeFeeData(amountAvailableCryptoPrecision.toFixed(), true)
+      if (!feeData) return
+      return bnOrZero(feeData.txFee).div(bn(10).pow(feeAsset.precision)).toPrecision()
     } catch (error) {
       // TODO: handle client side errors maybe add a toast?
       moduleLogger.error(
@@ -162,12 +162,12 @@ export const ExpiredWithdraw: React.FC<ExpiredWithdrawProps> = ({
         assets,
       )
     } else {
-      const estimatedGasCrypto = await getApproveGasData()
-      if (!estimatedGasCrypto) return
+      const feeData = await getApproveFeeData()
+      if (!feeData) return
       dispatch({
         type: FoxFarmingWithdrawActionType.SET_APPROVE,
         payload: {
-          estimatedGasCryptoPrecision: bnOrZero(estimatedGasCrypto.average.txFee)
+          estimatedGasCryptoPrecision: bnOrZero(feeData.txFee)
             .div(bn(10).pow(feeAsset.precision))
             .toPrecision(),
         },