-
Notifications
You must be signed in to change notification settings - Fork 2
Negotiation documentation #893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ac75d45 to
72c4f78
Compare
| current user is the provider) transactions that are in a state that | ||
| [requires provider attention](https://github.com/sharetribe/web-template/blob/main/src/transactions/transaction.js#L287) | ||
| 2. The amount of sales transactions determines the | ||
| 1. The template [makes two queries](TODO) that retrieve all sales |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just highlighting the TODO's here in case they are ready and missed - also line 121
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update these once the feature is released in template – the URLs should point to user.duck.js fetchCurrentUserNotifications function
| is the provider) that are in a state that | ||
| [requires customer attention](TODO) | ||
| 2. The number of relevant sales and order transactions determines the | ||
| [notification count](https://github.com/sharetribe/web-template/blob/main/src/ducks/user.duck.js#L105) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should maybe be this line: case FETCH_CURRENT_USER_NOTIFICATIONS_SUCCESS:
It currently points to case FETCH_CURRENT_USER_HAS_LISTINGS_ERROR:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Currently, the notification count is based on a single value from user state, but after the negotiation process is released, it's actually based on two values (customer notification count and provider notification count) that get combined in TopbarContainer mapStateToProps, so most likely this link should point there instead of anywhere in user.duck.js.
I've added more URL TODOs in this paragraph so I can update all of them at the same time once the feature is in Template.
|
Just a general comment that I think not all pages had the updated date - not sure if all of them need it, since some changes are really minor? but reminding just in case! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the article referenced yet - is this intentional, as in we'll update again when the feature is out to reveal the doc?
|
|
src/docs/concepts-transactions/default-negotiation-process/index.md
Outdated
Show resolved
Hide resolved
src/docs/concepts-transactions/default-negotiation-process/index.md
Outdated
Show resolved
Hide resolved
src/docs/concepts-transactions/default-negotiation-process/index.md
Outdated
Show resolved
Hide resolved
| published: true | ||
| --- | ||
|
|
||
| # Negotiation process overview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have that much prior knowledge of the technical details of this feature so these were the questions I had after reading the overview:
- How do I toggle between forward and reverse flows (is there a setting or are they different transaction process paths or are they both enabled by default)
- There is a mention that the process does not support bookings or stock. What kind of offering is the process optimised for?
- I am having a hard time to picture the process flow. What do you think of there be a visualisation (a simplification) depicting the general flow?
- How do I create a transaction process where a provider can initiate a transaction? Is this a new endpoint parameter or is it defined in the transaction process?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great questions! I'll incorporate these answers in the article and the rest of the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some clarifications now. I'll also check in with CA on the non-technical documentation and mention these questions – I think some of them will be better suited for a deeper discussion in the help center.
src/docs/concepts-transactions/default-negotiation-process/index.md
Outdated
Show resolved
Hide resolved
src/docs/concepts-transactions/default-negotiation-process/index.md
Outdated
Show resolved
Hide resolved
src/docs/concepts-transactions/default-negotiation-process/index.md
Outdated
Show resolved
Hide resolved
src/docs/concepts-transactions/default-negotiation-process/index.md
Outdated
Show resolved
Hide resolved
src/docs/concepts-transactions/default-negotiation-process/index.md
Outdated
Show resolved
Hide resolved
src/docs/concepts-users-and-authentication/users-and-authentication-in-flex/index.md
Outdated
Show resolved
Hide resolved
src/docs/howto-payments/how-to-integrate-3rd-party-payment-gateway/index.md
Outdated
Show resolved
Hide resolved
src/docs/concepts-transactions/change-transaction-process/index.md
Outdated
Show resolved
Hide resolved
5e73ce9 to
bf41e42
Compare
ec5c4be to
5b65216
Compare
Update documentation for the release of default negotiation process. With this change, we are also releasing a change that means providers can initiate transactions against customer listings. For this change, we are decoupling the concepts of
providerandlisting authorwhere relevant.