Make the repository clone correctly under Windows #3534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't recommend doing this. I don't intend to maintain my fork. Might even delete it at some point. Upstream is not responding to PRs, unfortunately. If somebody wants to rely on my patch, they should take it into their own fork. |
Contributor
Author
|
@senekor Sorry, I thought I could use your fork exactly because the base one is unmaintained for 6 years, and you already solved the problem. I didn't expect you to maintain it. I can create my own fork if you prefer, but won't maintain it either. If the upstream author (or anyone else) shows up, we can always switch back. |
keith-hall
approved these changes
Dec 28, 2025
Collaborator
keith-hall
left a comment
keith-hall
left a comment
There was a problem hiding this comment.
FYI: these days a better Jinja2 syntax would be https://github.com/Sublime-Instincts/BetterJinja but syntect doesn't support extends yet
keith-hall
force-pushed
the
windows-clone
branch
from
c20e696 to
56678dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, cloning this repository on Windows is a major pain because of the Jinja2 syntax, which contains a colon in a file name.
This PR changes the submodule URL from @Martin819's fork to @senekor's one, which adds a commit on top that renames the file.
I didn't add an entry to the changelog, as I suppose this is not a user-facing feature.
Fixes #2991