forked from hypertrace/javaagent
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implementation to get dynamic config during runtime #7
Draft
shashank11p
wants to merge
3
commits into
main
Choose a base branch
from
implementGetDynamicConfig
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
116 changes: 116 additions & 0 deletions
116
javaagent-core/src/test/java/org/hypertrace/agent/core/config/DynamicConfigServer.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| /* | ||
| * Copyright The Hypertrace Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.hypertrace.agent.core.config; | ||
|
|
||
| import io.grpc.Server; | ||
| import io.grpc.ServerBuilder; | ||
| import java.io.IOException; | ||
| import java.util.concurrent.TimeUnit; | ||
| import org.hypertrace.agent.config.ConfigurationServiceGrpc; | ||
| import org.hypertrace.agent.config.Service; | ||
|
|
||
| public class DynamicConfigServer { | ||
|
|
||
| private final Server server; | ||
| private Service.InitialConfigurationResponse initialConfigurationResponse; | ||
| private Service.UpdateConfigurationResponse updateConfigurationResponse; | ||
|
|
||
| public DynamicConfigServer(int port) { | ||
| server = ServerBuilder.forPort(port).addService(new DynamicConfigService()).build(); | ||
| } | ||
|
|
||
| /** Start serving requests. */ | ||
| public void start() throws IOException { | ||
| server.start(); | ||
| Runtime.getRuntime() | ||
| .addShutdownHook( | ||
| new Thread() { | ||
| @Override | ||
| public void run() { | ||
| // Use stderr here since the logger may have been reset by its JVM shutdown hook. | ||
| System.err.println("*** shutting down gRPC server since JVM is shutting down"); | ||
| try { | ||
| DynamicConfigServer.this.stop(); | ||
| } catch (InterruptedException e) { | ||
| e.printStackTrace(System.err); | ||
| } | ||
| System.err.println("*** server shut down"); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| /** Stop serving requests and shutdown resources. */ | ||
| public void stop() throws InterruptedException { | ||
| if (server != null) { | ||
| server.shutdown().awaitTermination(30, TimeUnit.SECONDS); | ||
| } | ||
| } | ||
|
|
||
| /** Await termination on the main thread since the grpc library uses daemon threads. */ | ||
| public void blockUntilShutdown() throws InterruptedException { | ||
| if (server != null) { | ||
| server.awaitTermination(); | ||
| } | ||
| } | ||
|
|
||
| public Service.InitialConfigurationResponse getInitialConfigurationResponse() { | ||
| return initialConfigurationResponse; | ||
| } | ||
|
|
||
| public void setInitialConfigurationResponse( | ||
| Service.InitialConfigurationResponse initialConfigurationResponse) { | ||
| this.initialConfigurationResponse = initialConfigurationResponse; | ||
| } | ||
|
|
||
| public Service.UpdateConfigurationResponse getUpdateConfigurationResponse() { | ||
| return updateConfigurationResponse; | ||
| } | ||
|
|
||
| public void setUpdateConfigurationResponse( | ||
| Service.UpdateConfigurationResponse updateConfigurationResponse) { | ||
| this.updateConfigurationResponse = updateConfigurationResponse; | ||
| } | ||
|
|
||
| /** Main method. This comment makes the linter happy. */ | ||
| public static void main(String[] args) throws Exception { | ||
| DynamicConfigServer server = new DynamicConfigServer(8980); | ||
| server.start(); | ||
| server.blockUntilShutdown(); | ||
| } | ||
|
|
||
| private class DynamicConfigService extends ConfigurationServiceGrpc.ConfigurationServiceImplBase { | ||
| @Override | ||
| public void initialConfiguration( | ||
| org.hypertrace.agent.config.Service.InitialConfigurationRequest request, | ||
| io.grpc.stub.StreamObserver< | ||
| org.hypertrace.agent.config.Service.InitialConfigurationResponse> | ||
| responseObserver) { | ||
|
|
||
| responseObserver.onNext(initialConfigurationResponse); | ||
| responseObserver.onCompleted(); | ||
| } | ||
|
|
||
| @Override | ||
| public void updateConfiguration( | ||
| org.hypertrace.agent.config.Service.UpdateConfigurationRequest request, | ||
| io.grpc.stub.StreamObserver<org.hypertrace.agent.config.Service.UpdateConfigurationResponse> | ||
| responseObserver) { | ||
| responseObserver.onNext(updateConfigurationResponse); | ||
| responseObserver.onCompleted(); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the field from the HypertraceConfig class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we worry about concurrent modifications (read/write) at the same time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is the field from HypertraceConfig class. We do not need to worry about concurrent modifications as it is a volatile field.