Fix pool.map so that order of results is retained#7
Open
emef wants to merge 2 commits intoshazow:masterfrom
Open
Fix pool.map so that order of results is retained#7emef wants to merge 2 commits intoshazow:masterfrom
pool.map so that order of results is retained#7emef wants to merge 2 commits intoshazow:masterfrom
Conversation
Owner
There was a problem hiding this comment.
What's the benefit of this addition?
Author
There was a problem hiding this comment.
Test failures raise an exception in the main thread, and do not shut the pools down. On my machine, this hangs up the entire test suite. By using self.pool() to create pools, we get automatic shutdowns regardless of test pass/failure.
Owner
There was a problem hiding this comment.
Fair enough, good catch! Can we change def pool(...) to def get_pool(...) please? Or maybe get_workerpool. Otherwise looks good.
Owner
|
@jtriley Any thoughts on this before I merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no guarantee in which order the threads will complete their task, so the map jobs must know the index their result should have in the final results list.
Also fixed the tests so that nosetests doesn't hang on a test failure (pool not properly shutdown)