Bump click to 8.4.2 - #263
Merged
Merged
Conversation
Moves click past 8.3.3, which fixes CVE-2026-7246 (command injection in click.edit). Nothing here calls the editor or pager helpers, so this is scanner hygiene rather than an exploitable path. Click is only pulled in transitively through uvicorn, whose CLI usage is unaffected by the 8.4.x changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the locked click version from 8.3.1 to 8.4.2, moving past 8.3.3 which fixes CVE-2026-7246 (command injection in click.edit via the editor/pager spawn path).
Nothing in this codebase calls click.edit or the pager helpers, so this is not exploitable here; the bump is to keep dependency scanners from flagging the lockfile. Click is only a transitive dependency through uvicorn's CLI, and the 8.4.x changes (ParamType/Parameter becoming abstract, help text and shell completion fixes) do not touch the plain-flag usage in the container entrypoint.
Lockfile-only change, generated with
uv lock --upgrade-package click.