Desktop (JVM) support - #74
Closed
shubhamsinghshubham777 wants to merge 3 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #73, here's my attempt to provide
JVM(Desktop) support for this library. The work is not done yet, I'm yet to write a sample and complete the implementation ofMediaDevicesbut I'm raising this draft PR so that I could get some feedback on the work I've done so far.Feel free to drop comments on how I could improve the code.
I'm planning to use the Realm Kotlin SDK and MongoDB for the DataSource in the JVM sample as Firebase is not available for Desktop. Feel free to suggest any better alternatives as we just need to write a barebones sample app.
I have also raised issues for the problems I'm facing while trying to implement
MediaDevices(devopvoid/webrtc-java#114) andDtmfSender(devopvoid/webrtc-java#115)