Remove deprecated --no-txt argument and apply code formatting #2686
+5
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the deprecated --no-txt command line argument - This addresses the TODO comment in sherlock.py about removing deprecated functionality - The --txt flag remains functional for explicitly enabling txt file output - Updated argument parser to clean up deprecated code path Resolves: Cleanup deprecated functionality Type: Enhancement Hacktoberfest contribution
- Improve spacing around operators and strings - Apply consistent formatting standards - Part of the cleanup contribution
|
This one seems to be a duplicate of #2603, which is staged for rel |
/rt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ppfeister Please see to this change
Description
This PR removes the deprecated
--no-txtcommand line argument as indicated by the TODO comment in the code, and applies some code formatting improvements.Changes Made
--no-txtargument and related code (10 lines removed)--txtflagTesting
--txtflag still works correctly--no-txtflag is properly rejectedNote on Test Results: 4 tests fail due to environment setup (tests expect global
sherlockcommand but we're using virtual environment). These failures are not related to the code changes - they're infrastructure/environment issues where tests try to runsherlockcommand directly but it's not in PATH. The failing tests are intest_ux.pyandtest_version.pyand relate to command execution, not the argument parsing changes made in this PR.Type of Change
Checklist
Related Issues
Addresses the TODO comment in
sherlock_project/sherlock.pyline 678 about removing deprecated--no-txtfunctionality.Impact
--txtflag continues to work exactly as beforeHacktoberfest Contribution 🎃