fix(ci): trigger rpm.yml on release:published instead of push:tags#84
Merged
Conversation
…tainer In the rockylinux:9 container, gh cannot discover the repository via git (no git remote context), causing gh release view to always fail. Setting GH_REPO at the job level makes all gh commands resolve the repo without needing git. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
The push:tags trigger fires before release-please creates the GitHub Release, so the wait-loop always times out in the rockylinux:9 container (gh cannot discover the repo via git, so gh release view always fails). Switch to release:published — same pattern as release.yml — so the release is guaranteed to exist when the workflow runs. Remove the wait-and-fallback step entirely. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
shigechika
changed the title
This was referenced May 8, 2026
shigechika
added a commit
that referenced
this pull request
May 8, 2026
Same fix as rpm.yml (#84): switch from push:tags to release:published so the GitHub Release is guaranteed to exist when the workflow fires. Remove the wait-and-fallback step (21 lines). Co-authored-by: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
push: tagsfires before release-please creates the GitHub Release. Inside therockylinux:9container,ghcan't discover the repository via git, sogh release viewalways fails — even when the release already exists. After 30 iterations the wait-loop times out, the fallbackgh release createruns, and fails with HTTP 422 because the release was created in the meantime.Previous fix attempts (#82) only patched individual
ghcalls but missed the architectural issue: the trigger itself fires too early.Fix
Switch to
release: published— the same pattern already used byrelease.yml(which has a comment explaining exactly this problem). The release is guaranteed to exist when the workflow fires, so the entire wait-and-fallback step can be removed.workflow_dispatchstill works for build testing; the upload step is gated ongithub.event_name == 'release'so it is skipped for manual runs.Changes
push: tags→release: publishedif: github.event_name == 'release'conditionGH_REPOenv var as safety net for remainingghcall🤖 Generated with Claude Code