fix: use UTC in fromtimestamp to avoid OSError on Windows for epoch≈0#14
Merged
Conversation
datetime.fromtimestamp(ts) raises OSError on Windows when ts is near 0 (pre-1970 local time). Passing tz=timezone.utc makes the call well-defined on all platforms; .astimezone() then converts to local time for display. Also applies the same fix to the two inline fromtimestamp calls in get_login_stats_by_hour. OSError removed from _format_ts except clause (now unreachable). Windows skipif guard on TestFormatTs::test_zero removed. Closes #4 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datetime.fromtimestamp(ts)raisesOSErroron Windows whentsis near 0 (pre-1970 values in local time). Passingtz=timezone.utcmakes the call well-defined on all platforms;.astimezone()then converts to local time for display — identical output for normal timestamps.fromtimestampcalls inget_login_stats_by_hour(lines 448/454), which had the same issue but were not covered by_format_ts.OSErrorremoved from the_format_tsexcept clause (now unreachable).@pytest.mark.skipif(sys.platform == "win32", ...)guard onTestFormatTs::test_zeroremoved;import sysandimport pytest(now unused) also removed.Test plan
uv run pytest -v— 70 tests pass (no skips on any platform)uv run ruff check+ruff format --check— cleanCloses #4
🤖 Generated with Claude Code