feat: support silent URL node with ?<url> syntax - #11
Open
shiosyakeyakini-info wants to merge 1 commit into
Open
feat: support silent URL node with ?<url> syntax#11shiosyakeyakini-info wants to merge 1 commit into
?<url> syntax#11shiosyakeyakini-info wants to merge 1 commit into
Conversation
Follows misskey-dev/mfm.js#141 (Review Approved upstream). - Add optional `silent` field to `MfmURL` (default false) - Accept `?<...>` in `urlAlt`, setting `silent: true` - Add tests mirroring the upstream PR Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
上流 misskey-dev/mfm.js#141
feat: silent url(upstream で Review Approved 済み)への追従です。?<https://example.com>構文をパースし、URL を表示しない silent なurlノードとして扱えるようにします。Changes
MfmURLに任意のsilentフィールドを追加(デフォルトfalse、props にも反映)urlAltパーサーで開き括弧を<に加えて?<も受理し、?<の場合はsilent: trueを設定Test
dart test… 全 163 件パス(新規 2 件含む)dart analyze… No issues foundNotes
MfmLinkのsilent(?[label](url)構文)は実装済みで、本 PR が対象とするのは URL ノード(?<url>)の silent です。🤖 Generated with Claude Code