Document FakeAuthenticator's deliberate leniencies#37
Merged
Conversation
Co-Authored-By: Claude Code
There was a problem hiding this comment.
Pull request overview
Documents two intentional limitations of FakeAuthenticator so test authors understand what their tests may not cover compared to real browser/WebAuthn behavior.
Changes:
- Expanded
FakeAuthenticatorclass docblock to describe the two deliberate simplifications (RP ID validation leniency; always “platform”/internalattachment). - Added a clarifying note to
createPasskey()docs about RP ID validation not being enforced like a real client.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the pre-1.0 review (item E):
FakeAuthenticatorhas two deliberate simplifications a test author should know their tests do not cover, and neither was documented:rpId/originsconfiguration passes in tests and only fails in a real browser;authenticatorAttachment: "platform",transports: ["internal"]).Docs-only: a paragraph on the class docblock plus a sentence on
createPasskey(). (The third previously-flagged leniency —backedUpcoupling BE+BS — was already documented on the constructor param.)Co-Authored-By: Claude Code