Cover coverage-guard.php with phpcs and PHPStan#42
Merged
Conversation
Root-level config files were listed in neither tool, which is how the file's nonstandard indentation went unnoticed. Co-Authored-By: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root-level config files were listed in neither tool — phpcs only linted
example/,src/,tests/and PHPStan only analysedsrc,tests— which is howcoverage-guard.php's nonstandard (tab) indentation went unnoticed before #41. Adds the file to both; it passes both checks with no code changes needed.Checked for similar gaps: the only other PHP outside the tools' scope is
example/symfony(deliberately excluded, documented in phpcs.xml.dist) andexample/plain-php, which phpcs lints but PHPStan intentionally does not analyse.Co-Authored-By: Claude Code