Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release workflow for shp CLI #61

Merged

Conversation

adambkaplan
Copy link
Member

Changes

  • Use gorelease to create binaries for windows, linux, and macOS on
    amd64 and arm64.
  • Run workflow whenever a semantic version tag is created.

Fixes #21

/kind cleanup

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

@openshift-ci openshift-ci bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none labels Oct 25, 2021
@openshift-ci openshift-ci bot requested review from otaviof and qu1queee October 25, 2021 20:16
@adambkaplan
Copy link
Member Author

/assign @SaschaSchwarze0

/cc @akram @otaviof

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2021

@adambkaplan: GitHub didn't allow me to request PR reviews from the following users: akram.

Note that only shipwright-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @SaschaSchwarze0

/cc @akram @otaviof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adambkaplan adambkaplan mentioned this pull request Oct 25, 2021
4 tasks
@adambkaplan
Copy link
Member Author

Example of how this will work (note that I will likely take this "release" link down once this PR merges):

https://github.com/adambkaplan/shipwright-cli/releases/tag/v0.0.1

To accomplish this all I had to was push a tag with a semantic version. As a follow-ups we can configure a workflow task that creates a semantic version tag, use the same/similar release notes generator as we do in shipwright-io/build, and so forth. I'd argue that this at least gets us to "minimum viable product."

@gabemontero
Copy link
Member

Example of how this will work (note that I will likely take this "release" link down once this PR merges):

https://github.com/adambkaplan/shipwright-cli/releases/tag/v0.0.1

To accomplish this all I had to was push a tag with a semantic version. As a follow-ups we can configure a workflow task that creates a semantic version tag, use the same/similar release notes generator as we do in shipwright-io/build, and so forth. I'd argue that this at least gets us to "minimum viable product."

cool / looks good... eventually I think we'll want to port https://github.com/shipwright-io/build/blob/main/.github/workflows/release.yaml#L22-L31 over here and leverage the release note plugin, but as this is our first release, and we are already past our target for that, let's do it in a follow up item

Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2021
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that the binary name in the package is not correct.

.goreleaser.yml Show resolved Hide resolved
@SaschaSchwarze0 SaschaSchwarze0 removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2021
.goreleaser.yml Show resolved Hide resolved
@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 26, 2021
- Use gorelease to create binaries for windows, linux, and macOS on
  amd64 and arm64.
- Run workflow whenever a semantic version tag is created.
- Binary is named `shp` and optimized for space efficiency.

Co-authored-by: Akram Ben Aissi <[email protected]>
Co-authored-by: Matthias Diester <[email protected]>
Co-authored-by: Sascha Schwarze <[email protected]>
@adambkaplan
Copy link
Member Author

@SaschaSchwarze0 @HeavyWombat incorporated your feedback & squashed commits.

Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e323291 into shipwright-io:main Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate release process
6 participants