-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release workflow for shp CLI #61
Release workflow for shp CLI #61
Conversation
/assign @SaschaSchwarze0 |
@adambkaplan: GitHub didn't allow me to request PR reviews from the following users: akram. Note that only shipwright-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Example of how this will work (note that I will likely take this "release" link down once this PR merges): https://github.com/adambkaplan/shipwright-cli/releases/tag/v0.0.1 To accomplish this all I had to was push a tag with a semantic version. As a follow-ups we can configure a workflow task that creates a semantic version tag, use the same/similar release notes generator as we do in shipwright-io/build, and so forth. I'd argue that this at least gets us to "minimum viable product." |
cool / looks good... eventually I think we'll want to port https://github.com/shipwright-io/build/blob/main/.github/workflows/release.yaml#L22-L31 over here and leverage the release note plugin, but as this is our first release, and we are already past our target for that, let's do it in a follow up item |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed that the binary name in the package is not correct.
- Use gorelease to create binaries for windows, linux, and macOS on amd64 and arm64. - Run workflow whenever a semantic version tag is created. - Binary is named `shp` and optimized for space efficiency. Co-authored-by: Akram Ben Aissi <[email protected]> Co-authored-by: Matthias Diester <[email protected]> Co-authored-by: Sascha Schwarze <[email protected]>
4995e35
to
5f62352
Compare
@SaschaSchwarze0 @HeavyWombat incorporated your feedback & squashed commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
amd64 and arm64.
Fixes #21
/kind cleanup
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes