Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHIP-0007: Release Shipwright CLI through Package Managers #16

Merged
merged 1 commit into from
Jul 13, 2021
Merged

SHIP-0007: Release Shipwright CLI through Package Managers #16

merged 1 commit into from
Jul 13, 2021

Conversation

HeavyWombat
Copy link
Contributor

TL;DR:

Users of CLI tools are accustomed to the usage of package managers to install a tool and to keep it up-to-date. The shp CLI tool should have an option to be installed with such a package manager.

@openshift-ci openshift-ci bot requested review from adambkaplan and sbose78 July 7, 2021 09:45
@HeavyWombat
Copy link
Contributor Author

It would also solve shipwright-io/cli#23.

qu1queee
qu1queee requested changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIP looks good to me, this is needed for CLI. I just have a minor request for change.

ships/0007-package-manager-releases.md Outdated Show resolved Hide resolved
@qu1queee qu1queee requested a review from otaviof July 8, 2021 07:09
@HeavyWombat HeavyWombat force-pushed the ship/package-manager branch from e78285d to 8e49847 Compare July 9, 2021 09:19
@HeavyWombat HeavyWombat requested a review from qu1queee July 9, 2021 09:19
qu1queee
qu1queee approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, approving, leaving the lgtm for someone in RH

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2021
@otaviof
Copy link
Member

otaviof commented Jul 13, 2021

Thanks putting it together, @HeavyWombat!

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2021
@openshift-merge-robot openshift-merge-robot merged commit c84e479 into shipwright-io:main Jul 13, 2021
@HeavyWombat HeavyWombat deleted the ship/package-manager branch February 12, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qu1queee qu1queee qu1queee approved these changes

@otaviof otaviof otaviof approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@sbose78 sbose78 Awaiting requested review from sbose78

Assignees

@otaviof otaviof

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HeavyWombat @otaviof @qu1queee @openshift-merge-robot