Phase 7#118
Open
jkkj wants to merge 27 commits intoshubham0204:mainfrom
Open
Conversation
…ChatScreenViewModel
Prevents crash when changing system prompt by calling unloadModel() before loadModel() in UpdateChatSettings handler, matching the pattern used in all other model reload paths.
- Fix race condition in SmolLMManager.unload() where deferred close()
would free a newly loaded model after settings change
- Add JNI exception handling for startCompletion and widen catches
from std::runtime_error to std::exception in loadModel/completionLoop
- Validate chat template with Jinja syntax check before passing to C++
- Replace llmModel!! with safe calls in ChatActivity
- Reload model on error when instance becomes unloaded
- Show human-readable names for downloaded whisper models
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding options and UI elements for the new functionality.