Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ctr extension #647

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomaszjonak
Copy link

This PR provides containerd ctr binary in a form of a stanadlone talos extension. Counterpart to siderolabs/pkgs#1186.

cc @redhatrises.

Closes #622

Adds ctr containerd helper binary under /usr/local/bin.

Closes siderolabs#622

Signed-off-by: Tomasz Jonak <[email protected]>
@smira
Copy link
Member

smira commented Mar 17, 2025

Same questions as in siderolabs/pkgs#1186, and also pkgs path is better than downloading binary release.

@redhatrises
Copy link

@smira with siderolabs/pkgs#1186 merged. Do we need to make changes to this PR?

@smira
Copy link
Member

smira commented Mar 19, 2025

@redhatrises I don't know, if you want ctr as a system extension, you need to make a PR to extensions - either new one, or updating this one? I don't know if you and @tomaszjonak are working together?

@tomaszjonak
Copy link
Author

@smira yes, we are working together. I will update this PR as needed.

and also pkgs path is better than downloading binary release

I'm not versed enough in talos build system. Could you expand on how this should be done. I.e is there another extension that utilizes such flow.

@smira
Copy link
Member

smira commented Mar 19, 2025

I don't know something that matches 100%, but e.g. https://raw.githubusercontent.com/smira/extensions/e974d6e1fcd28b064c37c4c2bec6c3cc8159f6c2/firmware/qlogic-firmware/pkg.yaml

So you take containerd container image built by pkgs and just extract ctr from it, and put it under /rootfs/usr/bin. Should be relatively simple.

You also might need to bump PKGS to be the latest (use git describe --tags in pkgs repo) in .kres.yaml and make rekres.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create extension with ctr binary
3 participants